docs

rm unused params

fix test

test workflow

security

add ci badge

.github/workflows/go-ci.yaml

@@ -7,23 +7,15 @@ on:
     branches: [ main ]
 
 jobs:
-  build:
+  # Common setup job that other jobs can depend on
+  setup:
     runs-on: ubuntu-latest
-
     steps:
-      # Checkout the repository
+      - uses: actions/checkout@v4
-      - name: Checkout code
+      - uses: actions/setup-go@v5
-        uses: actions/checkout@v4
-
-      # Set up Go environment
-      - name: Set up Go
-        uses: actions/setup-go@v5
         with:
-          go-version: '1.23' # Specify the Go version you are using
+          go-version: '1.23'
-
+      - uses: actions/cache@v4
-      # Cache Go modules
-      - name: Cache Go modules
-        uses: actions/cache@v4
         with:
           path: |
             ~/.cache/go-build
@@ -31,24 +23,36 @@ jobs:
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-
+      - run: go mod tidy
 
-      # Install Dependencies
+  # Lint job
-      - name: Install Dependencies
+  lint:
-        run: go mod tidy
+    needs: setup
-
+    runs-on: ubuntu-latest
-      # Run Linters using golangci-lint
+    steps:
-      - name: Lint Code
+      - uses: actions/checkout@v4
-        uses: golangci/golangci-lint-action@v6
+      - uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.60 # Specify the version of golangci-lint
+          version: v1.60
           args: --timeout 5m
 
-      # Run Tests
+  # Test job
-      - name: Run Tests
+  test:
-        run: go test ./... -v
+    needs: setup
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
+        with:
+          go-version: '1.23'
+      - run: go test ./... -v
 
-      # Security Analysis using gosec
+  # Security scan job
-      - name: Security Scan
+  security:
-        uses: securego/gosec@master
+    needs: setup
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: securego/gosec@master
         with:
           args: ./...

README.md

@@ -108,3 +108,14 @@ View errors:
 ```bash
 journalctl -u telegram-bot -p err
 ```
+
+## Testing
+
+The GitHub actions workflow already runs tests on every commit:
+
+> [![CI](https://github.com/HugeFrog24/go-telegram-bot/actions/workflows/go-ci.yaml/badge.svg?branch=main)](https://github.com/HugeFrog24/go-telegram-bot/actions/workflows/go-ci.yaml)
+
+However, you can run the tests locally using:
+```bash
+go test -race -v ./...
+```

bot.go

@@ -279,7 +279,7 @@ func initTelegramBot(token string, handleUpdate func(ctx context.Context, tgBot
 
 func (b *Bot) sendResponse(ctx context.Context, chatID int64, text string, businessConnectionID string) error {
 	// Pass the outgoing message through the centralized screen for storage
-	_, err := b.screenOutgoingMessage(chatID, text, businessConnectionID)
+	_, err := b.screenOutgoingMessage(chatID, text)
 	if err != nil {
 		ErrorLogger.Printf("Error storing assistant message: %v", err)
 		return err
@@ -306,7 +306,7 @@ func (b *Bot) sendResponse(ctx context.Context, chatID int64, text string, busin
 }
 
 // sendStats sends the bot statistics to the specified chat.
-func (b *Bot) sendStats(ctx context.Context, chatID int64, userID int64, username string, businessConnectionID string) {
+func (b *Bot) sendStats(ctx context.Context, chatID int64, businessConnectionID string) {
 	totalUsers, totalMessages, err := b.getStats()
 	if err != nil {
 		ErrorLogger.Printf("Error fetching stats: %v\n", err)
@@ -425,7 +425,7 @@ func (b *Bot) screenIncomingMessage(message *models.Message) (Message, error) {
 }
 
 // screenOutgoingMessage handles storing of outgoing messages.
-func (b *Bot) screenOutgoingMessage(chatID int64, response string, businessConnectionID string) (Message, error) {
+func (b *Bot) screenOutgoingMessage(chatID int64, response string) (Message, error) {
 	assistantMessage := b.createMessage(chatID, 0, "", string(anthropic.RoleAssistant), response, false)
 
 	// Store the message.

config.go

@@ -143,9 +143,11 @@ func validateConfig(config *BotConfig, ids, tokens map[string]bool) error {
 
 func loadConfig(filename string) (BotConfig, error) {
 	var config BotConfig
-	file, err := os.OpenFile(filename, os.O_RDONLY, 0)
+	// Use filepath.Clean before opening the file
+	cleanPath := filepath.Clean(filename)
+	file, err := os.OpenFile(cleanPath, os.O_RDONLY, 0)
 	if err != nil {
-		return config, fmt.Errorf("failed to open config file %s: %w", filename, err)
+		return config, fmt.Errorf("failed to open config file %s: %w", cleanPath, err)
 	}
 	defer file.Close()
 
@@ -165,9 +167,11 @@ func (c *BotConfig) Reload(configDir, filename string) error {
 		return fmt.Errorf("invalid config path: %w", err)
 	}
 
-	file, err := os.OpenFile(validPath, os.O_RDONLY, 0)
+	// Use filepath.Clean before opening the file
+	cleanPath := filepath.Clean(validPath)
+	file, err := os.OpenFile(cleanPath, os.O_RDONLY, 0)
 	if err != nil {
-		return fmt.Errorf("failed to open config file %s: %w", validPath, err)
+		return fmt.Errorf("failed to open config file %s: %w", cleanPath, err)
 	}
 	defer file.Close()
 

config_test.go

@@ -477,8 +477,12 @@ func TestLoadAllConfigs(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			// Clear the tempDir before each test
-			os.RemoveAll(tempDir)
+			if err := os.RemoveAll(tempDir); err != nil {
-			os.MkdirAll(tempDir, 0755)
+				t.Fatalf("Failed to remove temp dir: %v", err)
+			}
+			if err := os.MkdirAll(tempDir, 0755); err != nil {
+				t.Fatalf("Failed to create temp dir: %v", err)
+			}
 
 			// Write the test files directly
 			for filename, content := range tt.setupFiles {

handlers.go

@@ -48,7 +48,7 @@ func (b *Bot) handleUpdate(ctx context.Context, tgBot *bot.Bot, update *models.U
 				command := strings.TrimSpace(message.Text[entity.Offset : entity.Offset+entity.Length])
 				switch command {
 				case "/stats":
-					b.sendStats(ctx, chatID, userID, username, businessConnectionID)
+					b.sendStats(ctx, chatID, businessConnectionID)
 					return
 				case "/whoami":
 					b.sendWhoAmI(ctx, chatID, userID, username, businessConnectionID)